This is an automated email from the ASF dual-hosted git repository.
adamsaghy pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git
The following commit(s) were added to refs/heads/develop by this push:
new 111e28ed1 FINERACT-2081: Fix linked account validation
111e28ed1 is described below
commit 111e28ed1b1077544c022103890b3cab4d374770
Author: Adam Saghy <[email protected]>
AuthorDate: Tue Jun 11 19:28:55 2024 +0200
FINERACT-2081: Fix linked account validation
---
.../loanaccount/serialization/LoanApplicationValidator.java | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git
a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/serialization/LoanApplicationValidator.java
b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/serialization/LoanApplicationValidator.java
index 01bb58223..d8d78ed21 100644
---
a/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/serialization/LoanApplicationValidator.java
+++
b/fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/serialization/LoanApplicationValidator.java
@@ -1525,13 +1525,10 @@ public final class LoanApplicationValidator {
}
public void validateLinkedSavingsAccount(final JsonElement element,
DataValidatorBuilder baseDataValidator) {
- final boolean linkedAccountIdWasProvided =
this.fromApiJsonHelper.parameterExists(LoanApiConstants.linkAccountIdParameterName,
- element);
final Long linkedAccountId =
this.fromApiJsonHelper.extractLongNamed(LoanApiConstants.linkAccountIdParameterName,
element);
- if (linkedAccountIdWasProvided && linkedAccountId != null) {
+ if (linkedAccountId != null) {
baseDataValidator.reset().parameter(LoanApiConstants.linkAccountIdParameterName).value(linkedAccountId).ignoreIfNull()
.longGreaterThanZero();
-
final SavingsAccount savingsAccount =
savingsAccountRepository.findOneWithNotFoundDetection(linkedAccountId);
final Long clientId =
this.fromApiJsonHelper.extractLongNamed(LoanApiConstants.clientIdParameterName,
element);
if (savingsAccount.isNotActive()) {