marta-jankovics opened a new pull request, #3937:
URL: https://github.com/apache/fineract/pull/3937

   ## Description
   
   Details are present on the ticket. 
   Additionally the PR contains a small cleanup regarding the usage of `id` (or 
`value`), `code`, `description` (or `name`).
   
   EnumOptionData has these values:
   
   - id: T (String, Long or Integer or...) - identifier that is saved into the 
database and sent in the API requests
   - code: String - systemwide unique identifier, usually built of the name of 
the enum and the name of the enum option (eg. `statusEnum.create`), technical, 
not shown
   - description: String - user friendly display name, shown on the ui
   
   Please see an example in 
org.apache.fineract.infrastructure.dataqueries.data.StatusEnum
   
   
   ## Checklist
   
   Please make sure these boxes are checked before submitting your pull request 
- thanks!
   
   - [ ] Write the commit message as per 
https://github.com/apache/fineract/#pull-requests
   
   - [ ] Acknowledge that we will not review PRs that are not passing the build 
_("green")_ - it is your responsibility to get a proposed PR to pass the build, 
not primarily the project's maintainers.
   
   - [ ] Create/update unit or integration tests for verifying the changes made.
   
   - [ ] Follow coding conventions at 
https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
   
   - [ ] Add required Swagger annotation and update API documentation at 
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with 
details of any API changes
   
   - [ ] Submission is not a "code dump".  (Large changes can be made "in 
repository" via a branch.  Ask on the developer mailing list for guidance, if 
required.)
   
   FYI our guidelines for code reviews are at 
https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to