adamsaghy commented on code in PR #3939:
URL: https://github.com/apache/fineract/pull/3939#discussion_r1643436422
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java:
##########
@@ -539,7 +539,9 @@ public LoanTransactionData retrieveNewClosureDetails() {
@Override
public LoanApprovalData retrieveApprovalTemplate(final Long loanId) {
final Loan loan =
this.loanRepositoryWrapper.findOneWithNotFoundDetection(loanId, true);
- return new LoanApprovalData(loan.getProposedPrincipal(),
DateUtils.getBusinessLocalDate(), loan.getNetDisbursalAmount());
+ final CurrencyData currencyData = new
CurrencyData(loan.getCurrencyCode());
Review Comment:
Please send the full currency data, just as it sent for repayment template
call.
`return new CurrencyData(currencyCode, currencyName, currencyDigits,
inMultiplesOf, currencyDisplaySymbol, currencyNameCode);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]