adamsaghy commented on code in PR #3944:
URL: https://github.com/apache/fineract/pull/3944#discussion_r1651043536
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/jobs/service/StuckJobExecutorServiceImpl.java:
##########
@@ -39,14 +47,20 @@ public class StuckJobExecutorServiceImpl implements
StuckJobExecutorService {
private final JobExecutionRepository jobExecutionRepository;
private final TransactionTemplate transactionTemplate;
private final JobOperator jobOperator;
+ private final JobExplorer jobExplorer;
+ private final JobRepository jobRepository;
@Override
public void resumeStuckJob(String jobName) {
- List<Long> stuckJobIds = getStuckJobIds(jobName);
- if (isPartitionedJob(jobName) && areThereStuckJobs(jobName)) {
- restartPartitionedJobs(jobName, stuckJobIds);
- } else {
- restartTaskletJobs(stuckJobIds);
+ if (areThereStuckJobs(jobName)) {
+ final List<Long> stuckJobIds = getStuckJobIds(jobName);
+ stuckJobIds.forEach(stuckJobId -> markAsFailed(stuckJobId));
Review Comment:
It is still incorrect to immediately mark the job as failed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
