adamsaghy commented on code in PR #3951:
URL: https://github.com/apache/fineract/pull/3951#discussion_r1663717287
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanproduct/api/LoanProductsApiResourceSwagger.java:
##########
@@ -157,6 +157,8 @@ private PostLoanProductsRequest() {}
public Long delinquencyBucketId;
@Schema(example = "false")
public Boolean enableInstallmentLevelDelinquency;
+ @Schema(example = "false")
+ public Boolean useDueRepaymentGlobalConfigs;
Review Comment:
I still believe we should not have the which indicates whether it is coming
from global configuration or not. I would simply leave these fields as optional
and if user does not fill them, it is coming from global configurations. If
user provide a value then that will be used instead of the one from global
configurations. Additionally we can enhance further and return the values from
global configurations and we can show it on the UI to inform the user if
nothing is sent, those value will be used, but they should be different values
and do not send it back to backend!
What are your thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
