adamsaghy commented on code in PR #3952:
URL: https://github.com/apache/fineract/pull/3952#discussion_r1663720063
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/service/LoanScheduleAssembler.java:
##########
@@ -466,7 +467,9 @@ private LoanApplicationTerms
assembleLoanApplicationTermsFrom(final JsonElement
final boolean isPrincipalCompoundingDisabledForOverdueLoans =
this.configurationDomainService
.isPrincipalCompoundingDisabledForOverdueLoans();
- final boolean isDownPaymentEnabled =
loanProduct.getLoanProductRelatedDetail().isEnableDownPayment();
+ final boolean isDownPaymentEnabled =
validateDownPaymentAttribute(loanProduct.getLoanProductRelatedDetail().isEnableDownPayment(),
Review Comment:
Please move this into the loan validator!
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/service/LoanScheduleAssembler.java:
##########
@@ -1379,6 +1382,21 @@ public void updateLoanApplicationAttributes(JsonCommand
command, Loan loan, Map<
changes.put(LoanProductConstants.IS_EQUAL_AMORTIZATION_PARAM,
newValue);
loanProductRelatedDetail.setEqualAmortization(newValue);
}
+
+ final boolean isDownPaymentEnabled = validateDownPaymentAttribute(
Review Comment:
Please move this into the loan validator!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
