adamsaghy commented on code in PR #3973:
URL: https://github.com/apache/fineract/pull/3973#discussion_r1679171358
##########
fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/AccrualBasedAccountingProcessorForSavings.java:
##########
@@ -182,9 +182,16 @@ else if
(savingsTransactionDTO.getTransactionType().isInterestPosting()) {
else if (savingsTransactionDTO.getTransactionType().isAccrual()) {
// Post journal entry for Accrual Recognition
if
(savingsTransactionDTO.getAmount().compareTo(BigDecimal.ZERO) > 0) {
-
this.helper.createCashBasedJournalEntriesAndReversalsForSavings(office,
currencyCode,
-
AccrualAccountsForSavings.INTEREST_ON_SAVINGS.getValue(),
AccrualAccountsForSavings.INTEREST_PAYABLE.getValue(),
- savingsProductId, paymentTypeId, savingsId,
transactionId, transactionDate, amount, isReversal);
+ if (feePayments.size() > 0 || penaltyPayments.size() > 0) {
+
this.helper.createCashBasedJournalEntriesAndReversalsForSavings(office,
currencyCode,
Review Comment:
Would it make sense to only gather the proper credit and debit accounts into
a variable and after just call one time the
`this.helper.createCashBasedJournalEntriesAndReversalsForSavings` method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
