adamsaghy commented on code in PR #3977:
URL: https://github.com/apache/fineract/pull/3977#discussion_r1680865405
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java:
##########
@@ -1164,7 +1164,7 @@ private ChangedTransactionDetail
reprocessChangedLoanTransactions(Loan loan,
@Transactional
@Override
- public Loan makeAccrualActivityTransaction(Loan loan, final
LoanRepaymentScheduleInstallment installment,
+ public void makeAccrualActivityTransaction(Loan loan, final
LoanRepaymentScheduleInstallment installment,
Review Comment:
If we are explicitly saving the loan again, returning the Loan entity would
be advisable hence during merge the original instance got detached.
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java:
##########
@@ -1175,10 +1175,11 @@ public Loan makeAccrualActivityTransaction(Loan loan,
final LoanRepaymentSchedul
loan.addLoanTransaction(newAccrualActivityTransaction);
Review Comment:
Do we need to explicitly save and flush?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
