adamsaghy commented on code in PR #3973:
URL: https://github.com/apache/fineract/pull/3973#discussion_r1680880738
##########
fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/AccrualBasedAccountingProcessorForSavings.java:
##########
@@ -59,23 +59,23 @@ public void createJournalEntriesForSavings(final SavingsDTO
savingsDTO) {
if (savingsTransactionDTO.getTransactionType().isWithdrawal() &&
savingsTransactionDTO.isOverdraftTransaction()) {
boolean isPositive =
amount.subtract(overdraftAmount).compareTo(BigDecimal.ZERO) > 0;
if (savingsTransactionDTO.isAccountTransfer()) {
-
this.helper.createCashBasedJournalEntriesAndReversalsForSavings(office,
currencyCode,
Review Comment:
I am not sure this is correct. You just changed from cash based journal
entries to accrual based one without any condition. I am assuming accounting
wise after this PR cash based and accrual based can be selected and both should
work. But here you are overriding the behaviour. Am i missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
