alberto-art3ch opened a new pull request, #3997:
URL: https://github.com/apache/fineract/pull/3997
## Description
Describe the changes made and why they were made.
Exists a performance in the loans due to lots of transactions like
repayments made on the loan, accruals and some of the real-time evaluations in
below GET api uses loan.getTransactions and it takes more than 20seconds to
return the response.
```
/fineract-provider/api/v1/loans/{loanId}
/fineract-provider/api/v1/loans/external-id/{externalloanId}
```
By knowing that we are introducing daily accruals in interest bearing
product, its going to fail. Please rewrite the loading transactions by filter
in the JPA query
[FINERACT-2111](https://issues.apache.org/jira/browse/FINERACT-2111)
## Checklist
Please make sure these boxes are checked before submitting your pull request
- thanks!
- [ ] Write the commit message as per
https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build
_("green")_ - it is your responsibility to get a proposed PR to pass the build,
not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at
https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with
details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in
repository" via a branch. Ask on the developer mailing list for guidance, if
required.)
FYI our guidelines for code reviews are at
https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
