adamsaghy commented on code in PR #4000:
URL: https://github.com/apache/fineract/pull/4000#discussion_r1700008845
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/data/LoanSchedulePeriodData.java:
##########
@@ -402,6 +403,23 @@ private BigDecimal defaultToZeroIfNull(final BigDecimal
possibleNullValue) {
return value;
}
+ public BigDecimal getRatePerDay() {
+ return
getInterestOriginalDue().divide(BigDecimal.valueOf(getDaysInPeriod()),
MoneyHelper.getMathContext());
+ }
+
+ public boolean isActualPeriod(final LocalDate businessDate) {
Review Comment:
Misleading hence `actual period` should include the due date, but now we
need a logic which does not include it. Would you mind to rename it for
something more specific? Example: `isActualPeriodForNotDuePayableCalculation`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
