marta-jankovics opened a new pull request, #4037:
URL: https://github.com/apache/fineract/pull/4037

   ## Description
   
   [Describe the changes made and why they were made.
   
   Ignore if these details are present on the associated [Apache Fineract JIRA 
ticket](https://github.com/apache/fineract/pull/1284).](https://issues.apache.org/jira/browse/FINERACT-2119)
   
   New field on job table: 
   short_name VARCHAR(8) NNULL, Unique
   Example: ACC_AATR (Add Accrual Transactions) - first part is like a 
namespace, second part is specific for the job
    
   namespaces:
   LA: Loan Account
   SA: Savings Account
   SH: Shares
   ACC: Accounting
   STI: Standing Instruction
   EM: Email sending
   SMS: Sms sending
   BDT: Business Date
   COM: Commands
   EXE: External Events
   
   New API endpoints:
   These API endpoints were added by the story above. 
   GET /v1/jobs/short-name/{shortName}
   GET /v1/jobs/short-name/{shortName}/runhistory
   POST /v1/jobs/short-name/{shortName}
   PUT /v1/jobs/short-name/{shortName}
   
   ## Checklist
   
   Please make sure these boxes are checked before submitting your pull request 
- thanks!
   
   - [ ] Write the commit message as per 
https://github.com/apache/fineract/#pull-requests
   
   - [ ] Acknowledge that we will not review PRs that are not passing the build 
_("green")_ - it is your responsibility to get a proposed PR to pass the build, 
not primarily the project's maintainers.
   
   - [ ] Create/update unit or integration tests for verifying the changes made.
   
   - [ ] Follow coding conventions at 
https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
   
   - [ ] Add required Swagger annotation and update API documentation at 
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with 
details of any API changes
   
   - [ ] Submission is not a "code dump".  (Large changes can be made "in 
repository" via a branch.  Ask on the developer mailing list for guidance, if 
required.)
   
   FYI our guidelines for code reviews are at 
https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to