adamsaghy commented on code in PR #4098:
URL: https://github.com/apache/fineract/pull/4098#discussion_r1800056240
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/ExternalBusinessEventTest.java:
##########
@@ -297,6 +342,31 @@ && loanTermVariationsMatch((List<Map<String, Object>>)
externalEvent.getPayLoad(
}
}
+ public void verifyLoanTransactionBusinessEvents(BusinessEvent...
businessEvents) {
+ List<ExternalEventDTO> allExternalEvents =
ExternalEventHelper.getAllExternalEvents(requestSpec, responseSpec);
+ logBusinessEvents(allExternalEvents);
+ Assertions.assertNotNull(businessEvents);
+ Assertions.assertNotNull(allExternalEvents);
+ Assertions.assertTrue(businessEvents.length <=
allExternalEvents.size(),
+ "Expected business event count is less than actual. Expected:
" + businessEvents.length + " Actual: "
+ + allExternalEvents.size());
+ DateTimeFormatter formatter =
DateTimeFormatter.ofPattern(DATETIME_PATTERN, Locale.ENGLISH);
+ for (BusinessEvent businessEvent : businessEvents) {
+ long count = allExternalEvents.stream().filter(externalEvent -> {
+
+ Object netDisbursalAmount =
externalEvent.getPayLoad().get("netDisbursalAmount");
+ Object outstandingLoanBalance =
externalEvent.getPayLoad().get("outstandingLoanBalance");
+ var businessDate =
LocalDate.parse(businessEvent.getBusinessDate(), formatter);
+
+ return Objects.equals(externalEvent.getType(),
businessEvent.getType())
+ && Objects.equals(externalEvent.getBusinessDate(),
businessDate)
+ && Objects.equals(netDisbursalAmount,
businessEvent.getPrincipalDisbursed())
Review Comment:
it does not check neither transaction amount, neither portions... Would you
mind to change it to fit better for validating transaction business event?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
