adamsaghy commented on code in PR #4132:
URL: https://github.com/apache/fineract/pull/4132#discussion_r1820749546
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/domain/ProgressiveLoanScheduleGenerator.java:
##########
@@ -280,6 +280,9 @@ public OutstandingAmountsDTO
calculatePrepaymentAmount(MonetaryCurrency currency
.principal(result.getOutstandingBalance()) //
.interest(result.getPayableInterest());
+ installments.stream().filter(installment ->
installment.getDueDate().isBefore(onDate) ||
installment.getDueDate().isEqual(onDate))
Review Comment:
I am afraid the `|| installment.getDueDate().isEqual(onDate)` is still
incorrect as if the `onDate` is on the same day as the installment due date,
that means that is the "actual" installment and we already calculated the
payable interest for the actual installment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]