adamsaghy commented on code in PR #4133:
URL: https://github.com/apache/fineract/pull/4133#discussion_r1821521317


##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java:
##########
@@ -2686,6 +2686,19 @@ public ChangedTransactionDetail 
adjustExistingTransaction(final LoanTransaction
         transactionForAdjustment.reverse(reversalExternalId);
         transactionForAdjustment.manuallyAdjustedOrReversed();
 
+        if 
(transactionForAdjustment.getTypeOf().equals(LoanTransactionType.MERCHANT_ISSUED_REFUND))
 {
+            for (LoanTransaction loanTransaction : getLoanTransactions()) {

Review Comment:
   You might wanna rewrite this foreach to use stream api and if it finds 
suitable related transaction, then reverse it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to