adamsaghy commented on code in PR #4145:
URL: https://github.com/apache/fineract/pull/4145#discussion_r1829441092


##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java:
##########
@@ -742,9 +742,22 @@ private static LoanTransaction 
useOldTransactionIfApplicable(LoanTransaction old
         return null;
     }
 
-    protected void createNewTransaction(LoanTransaction oldTransaction, 
LoanTransaction newTransaction, TransactionCtx ctx) {
+    protected void createNewTransaction(final LoanTransaction oldTransaction, 
final LoanTransaction newTransaction,
+            final TransactionCtx ctx) {
         oldTransaction.updateExternalId(null);
         oldTransaction.getLoanChargesPaid().clear();
+
+        if (newTransaction.getTypeOf().isInterestRefund()) {

Review Comment:
   I am not sure it is correct. We should create new relationship between 
interest refund and merchant issued refund. If i understand correctly here, you 
are trying to update the old one instead...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to