adamsaghy commented on code in PR #4144:
URL: https://github.com/apache/fineract/pull/4144#discussion_r1841812938
##########
fineract-accounting/src/main/java/org/apache/fineract/accounting/producttoaccountmapping/domain/ProductToGLAccountMappingRepository.java:
##########
@@ -61,4 +61,8 @@ List<ProductToGLAccountMapping>
findAllPenaltyToIncomeAccountMappings(@Param("pr
@Param("productType") int productType);
List<ProductToGLAccountMapping> findByProductIdAndProductType(Long
productId, int productType);
+
+ @Query("select mapping from ProductToGLAccountMapping mapping where
mapping.productId =:productId and mapping.productType =:productType and
mapping.paymentType is not NULL and mapping.chargeOffReasonId is not NULL")
+ List<ProductToGLAccountMapping>
findAllChargesOffReasonsMappings(@Param("productId") Long productId,
Review Comment:
I dont think we need `mapping.paymentType is not NULL`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]