meonkeys commented on code in PR #4177:
URL: https://github.com/apache/fineract/pull/4177#discussion_r1852618612


##########
fineract-provider/src/main/java/org/apache/fineract/ServerApplication.java:
##########
@@ -54,6 +54,7 @@ private static SpringApplicationBuilder 
configureApplication(SpringApplicationBu
     }
 
     public static void main(String[] args) throws IOException {
+        System.setProperty("liquibase.analytics.enabled", "false");

Review Comment:
   @kjozsa: yes, it does.
   
   @kjozsa and @IOhacker: how about we go with just this simple static 
initializer in TenantDatabaseUpgradeService:
   
   ```java
   static {
       System.setProperty("liquibase.analytics.enabled", "false");
   }
   ```
   
   I can't imagine anyone *wanting* to set the flag to `true`, and it would be 
many fewer lines of code just to hardcode it to `"false"` in this manner rather 
than provide a configurable setting. If there's demand to make it configurable 
later, we could of course do that. I feel like our use of Liquibase is up to 
us, though. An under the hood / upstream decision we get to make. Thoughts?
   
   Also, is it clear that we *must* use `System.setProperty`? Our only other 
alternative is to use an environment setting 
`LIQUIBASE_ANALYTICS_ENABLED=false`, visible to the Java VM before/as it 
initializes. I don't see any way in the Liquibase API to disable phoning home 
at runtime.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to