marta-jankovics commented on code in PR #4220:
URL: https://github.com/apache/fineract/pull/4220#discussion_r1883720961
##########
fineract-e2e-tests-core/src/test/java/org/apache/fineract/test/helper/ErrorMessageHelper.java:
##########
@@ -348,9 +348,18 @@ public static String
wrongDataInDelinquentLastRepaymentDate(String actual, Strin
}
public static String wrongLoanStatus(Integer actual, Integer expected) {
+ return wrongLoanStatus(null, actual, expected);
+ }
+
+ public static String wrongLoanStatus(String resourceId, Integer actual,
Integer expected) {
String actualToStr = actual.toString();
String expectedToStr = expected.toString();
- return String.format("Wrong Loan status ID. Actual ID is: %s - But
expected ID is: %s", actualToStr, expectedToStr);
+ String prefx = "Wrong Loan status ID";
+ String postfx = ". Actual ID is: %s - But expected ID is: %s";
+ if (resourceId != null) {
+ return String.format(prefx + " of resource %s" + postfx,
resourceId, actualToStr, expectedToStr);
+ }
+ return String.format(prefx + postfx, actualToStr, expectedToStr);
Review Comment:
Agree, me neither.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
