(fineract) branch develop updated: FINERACT-1971: Fix boolean values used in Loan product charge-off reasons accounting mappings

[adamsaghy]

This is an automated email from the ASF dual-hosted git repository.

adamsaghy pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git


The following commit(s) were added to refs/heads/develop by this push:
     new 8716751c8 FINERACT-1971: Fix boolean values used in Loan product 
charge-off reasons accounting mappings
8716751c8 is described below

commit 8716751c882503155f1f4e2001cfb4067bba7a29
Author: Jose Alberto Hernandez <alberto@black-box.local>
AuthorDate: Fri Dec 13 05:13:56 2024 -0500

    FINERACT-1971: Fix boolean values used in Loan product charge-off reasons 
accounting mappings
---
 .../ProductToGLAccountMappingReadPlatformServiceImpl.java      | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git 
a/fineract-accounting/src/main/java/org/apache/fineract/accounting/producttoaccountmapping/service/ProductToGLAccountMappingReadPlatformServiceImpl.java
 
b/fineract-accounting/src/main/java/org/apache/fineract/accounting/producttoaccountmapping/service/ProductToGLAccountMappingReadPlatformServiceImpl.java
index c880fd6db..1803d12f1 100644
--- 
a/fineract-accounting/src/main/java/org/apache/fineract/accounting/producttoaccountmapping/service/ProductToGLAccountMappingReadPlatformServiceImpl.java
+++ 
b/fineract-accounting/src/main/java/org/apache/fineract/accounting/producttoaccountmapping/service/ProductToGLAccountMappingReadPlatformServiceImpl.java
@@ -88,8 +88,8 @@ public class ProductToGLAccountMappingReadPlatformServiceImpl 
implements Product
             final String codeValue = rs.getString("codeValueName");
             final String codeDescription = rs.getString("codeDescription");
             final Integer orderPosition = rs.getInt("orderPosition");
-            final Integer isActive = rs.getInt("isActive");
-            final Integer isMandatory = rs.getInt("isMandatory");
+            final Boolean isActive = rs.getBoolean("isActive");
+            final Boolean isMandatory = rs.getBoolean("isMandatory");
 
             final Map<String, Object> loanProductToGLAccountMap = new 
LinkedHashMap<>(5);
             loanProductToGLAccountMap.put("id", id);
@@ -377,10 +377,8 @@ public class 
ProductToGLAccountMappingReadPlatformServiceImpl implements Product
             final String codeValue = (String) 
chargeOffReasonMap.get("codeValue");
             final String codeDescription = (String) 
chargeOffReasonMap.get("codeDescription");
             final Integer orderPosition = (Integer) 
chargeOffReasonMap.get("orderPosition");
-            final Integer isActive = (Integer) 
chargeOffReasonMap.get("isActive");
-            final Integer isMandatory = (Integer) 
chargeOffReasonMap.get("isMandatory");
-            final boolean active = isActive != null && isActive == 1;
-            final boolean mandatory = isMandatory != null && isMandatory == 1;
+            final Boolean active = (Boolean) 
chargeOffReasonMap.get("isActive");
+            final Boolean mandatory = (Boolean) 
chargeOffReasonMap.get("isMandatory");
             final CodeValueData chargeOffReasonsCodeValue = 
CodeValueData.builder().id(Long.valueOf(chargeOffReasonId)).name(codeValue)
                     
.description(codeDescription).position(orderPosition).active(active).mandatory(mandatory).build();