marta-jankovics commented on code in PR #4228:
URL: https://github.com/apache/fineract/pull/4228#discussion_r1890065131
##########
fineract-accounting/src/main/java/org/apache/fineract/accounting/producttoaccountmapping/domain/ProductToGLAccountMapping.java:
##########
@@ -63,13 +64,14 @@ public class ProductToGLAccountMapping extends
AbstractPersistableCustom<Long> {
@Column(name = "financial_account_type", nullable = true)
private int financialAccountType;
- @Column(name = "charge_off_reason_id", nullable = true)
- private Long chargeOffReasonId;
+ @ManyToOne
+ @JoinColumn(name = "charge_off_reason_id", nullable = true)
+ private CodeValue chargeOffReason;
public static ProductToGLAccountMapping createNew(final GLAccount
glAccount, final Long productId, final int productType,
- final int financialAccountType, final Long chargeOffReasonId) {
+ final int financialAccountType, final CodeValue chargeOffReasonId)
{
Review Comment:
minor:could you please rename the parameter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
