mariiaKraievska commented on code in PR #4234:
URL: https://github.com/apache/fineract/pull/4234#discussion_r1898494130
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanScheduleService.java:
##########
@@ -54,7 +54,7 @@ public void regenerateRepaymentSchedule(final Loan loan,
final ScheduleGenerator
}
public void recalculateScheduleFromLastTransaction(final Loan loan, final
ScheduleGeneratorDTO generatorDTO) {
- if (loan.repaymentScheduleDetail().isInterestRecalculationEnabled()) {
+ if (loan.repaymentScheduleDetail().isInterestRecalculationEnabled() &&
!loan.isChargedOff()) {
Review Comment:
When you call loan.isChargedOff(), it simply checks whether the loan has
been charged off. As a result, you might skip the recalculation for
installments that have dates earlier than the charge-off transaction. As far as
I understand, you need to stop recalculating interest only AFTER the date of
the charge-off transaction. Perhaps my PR could help you:
https://github.com/apache/fineract/pull/4236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
