adamsaghy commented on code in PR #4236:
URL: https://github.com/apache/fineract/pull/4236#discussion_r1899440905
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java:
##########
@@ -3569,4 +3569,8 @@ public LoanRepaymentScheduleTransactionProcessor
getTransactionProcessor() {
public boolean isProgressiveSchedule() {
return getLoanProductRelatedDetail().getLoanScheduleType() ==
PROGRESSIVE;
}
+
+ public boolean isTransactionBeforeChargeOff(final boolean isChargedOff) {
+ return !isChargedOff ||
!LoanChargeOffBehaviour.ZERO_INTEREST.equals(this.getLoanProductRelatedDetail().getChargeOffBehaviour());
Review Comment:
Why do we need this
`!LoanChargeOffBehaviour.ZERO_INTEREST.equals(this.getLoanProductRelatedDetail().getChargeOffBehaviour()`
condition?
I think this whole method can be switched with `!ctx.isChargedOff()`.
Am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
