adamsaghy commented on code in PR #4269:
URL: https://github.com/apache/fineract/pull/4269#discussion_r1923309134


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/ProgressiveLoanInterestRefundServiceImpl.java:
##########
@@ -81,6 +85,13 @@ private Money 
recalculateTotalInterest(AdvancedPaymentScheduleTransactionProcess
         List<LoanRepaymentScheduleInstallment> installmentsToReprocess = new 
ArrayList<>(
                 loan.getRepaymentScheduleInstallments().stream().filter(i -> 
!i.isReAged() && !i.isAdditional()).toList());
 
+        if (loan.getLoanProductRelatedDetail() != null

Review Comment:
   Same logic can applied here like in 
`ProgressiveLoanSummaryDataProvider.java:computeTotalUnpaidPayableNotDueInterestAmountOnActualPeriod`
   
   If the loan is charged-off we dont need to recalculate interest, rather just 
simply returning the total interest outstanding of the loan!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to