janez89 commented on code in PR #4244:
URL: https://github.com/apache/fineract/pull/4244#discussion_r1923400813


##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanproduct/calc/ProgressiveEMICalculator.java:
##########
@@ -315,6 +315,13 @@ private void calculateEMIValueAndRateFactors(final 
LocalDate calculateFromRepaym
         }
     }
 
+    void calculateRateFactorsForInterestPause(final 
ProgressiveLoanInterestScheduleModel scheduleModel) {

Review Comment:
   The `start date` should be a method parameter. You have to recalculate from 
the exact period when the change happened until the end.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to