adamsaghy commented on code in PR #4288:
URL: https://github.com/apache/fineract/pull/4288#discussion_r1936937628
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/data/ProgressiveLoanInterestScheduleModel.java:
##########
@@ -175,7 +176,9 @@ public Optional<RepaymentPeriod>
updateInterestPeriodsForInterestPause(final Loc
private boolean isPeriodInRange(final RepaymentPeriod repaymentPeriod,
final LocalDate fromDate, final LocalDate endDate) {
return DateUtils.isDateInRangeFromExclusiveToInclusive(fromDate,
repaymentPeriod.getFromDate(), repaymentPeriod.getDueDate())
- || DateUtils.isDateInRangeFromExclusiveToInclusive(endDate,
repaymentPeriod.getFromDate(), repaymentPeriod.getDueDate());
+ || DateUtils.isDateInRangeFromExclusiveToInclusive(endDate,
repaymentPeriod.getFromDate(), repaymentPeriod.getDueDate())
+ || (!DateUtils.isAfter(fromDate, repaymentPeriod.getFromDate())
Review Comment:
i am not sure about this last condition. Can you please elaborate why we
need this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
