kjozsa commented on code in PR #4297:
URL: https://github.com/apache/fineract/pull/4297#discussion_r1939188316
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/data/ProgressiveLoanInterestScheduleModel.java:
##########
@@ -48,26 +52,27 @@ public class ProgressiveLoanInterestScheduleModel {
private final List<RepaymentPeriod> repaymentPeriods;
private final TreeSet<InterestRate> interestRates;
private final LoanProductMinimumRepaymentScheduleRelatedDetail
loanProductRelatedDetail;
- private final LoanTermVariationsDataWrapper loanTermVariations;
+ private final Map<LoanTermVariationType, List<LoanTermVariationsData>>
loanTermVariations;
private final Integer installmentAmountInMultiplesOf;
- private final MathContext mc;
- private final Money zero;
+ private final transient MathContext mc;
Review Comment:
do we need these fields to be transient all around?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
