adamsaghy commented on code in PR #4307:
URL: https://github.com/apache/fineract/pull/4307#discussion_r1944453460
##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/ResultsetColumnHeaderData.java:
##########
@@ -39,240 +51,85 @@ public final class ResultsetColumnHeaderData implements
Serializable {
private final boolean isColumnPrimaryKey;
private final boolean isColumnUnique;
private final boolean isColumnIndexed;
-
private final List<ResultsetColumnValueData> columnValues;
private final String columnCode;
public static ResultsetColumnHeaderData basic(final String columnName,
final String columnType, DatabaseType dialect) {
- final Long columnLength = null;
- final boolean columnNullable = false;
- final boolean columnIsPrimaryKey = false;
- final List<ResultsetColumnValueData> columnValues = new ArrayList<>();
- final String columnCode = null;
- final boolean columnIsUnique = false;
- final boolean columnIsIndexed = false;
- return new ResultsetColumnHeaderData(columnName, columnType,
columnLength, columnNullable, columnIsPrimaryKey, columnValues,
- columnCode, columnIsUnique, columnIsIndexed, dialect);
+ return ResultsetColumnHeaderData.builder()
+ .columnName(columnName)
+ .columnType(JdbcJavaType.getByTypeName(dialect,
adjustColumnType(columnType), true))
+ .columnLength(null)
Review Comment:
Same goes for primitive boolean types. It is nice to explicitly set, but in
the other hand it is unnecessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
