adamsaghy commented on code in PR #4299:
URL: https://github.com/apache/fineract/pull/4299#discussion_r1946168806


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanAccrualsProcessingServiceImpl.java:
##########
@@ -246,7 +246,13 @@ public void processIncomePostingAndAccruals(@NotNull Loan 
loan) {
     @Override
     public void processAccrualsOnLoanClosure(@NotNull Loan loan) {
         // check and process accruals for loan WITHOUT interest recalculation 
details and compounding posted as income
-        addAccruals(loan, 
loan.getLastLoanRepaymentScheduleInstallment().getDueDate(), false, true, 
false);
+        LocalDate accrualDate = getFinalAccrualTransactionDate(loan);

Review Comment:
   `processIncomeAndAccrualTransactionOnLoanClosure` should calculate and add 
the accrual, no?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to