adamsaghy commented on code in PR #4314:
URL: https://github.com/apache/fineract/pull/4314#discussion_r1948911831
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/data/LoanSchedulePeriodData.java:
##########
@@ -156,11 +158,13 @@ public static LoanSchedulePeriodData
periodWithPayments(final Integer periodNumb
final BigDecimal totalPaidLateForPeriod, final BigDecimal
totalWaived, final BigDecimal totalWrittenOff,
final BigDecimal totalCredits, final boolean isDownPayment, final
BigDecimal totalAccruedInterest) {
- BigDecimal totalDue = MathUtil.add(principalOriginalDue, interestDue,
feeChargesDue, penaltyChargesDue);
- BigDecimal totalOutstanding = MathUtil.add(principalOutstanding,
interestOutstanding, feeChargesOutstanding,
+ final MathContext mc = new MathContext(MoneyHelper.PRECISION_16,
MoneyHelper.getMathContext().getRoundingMode());
Review Comment:
It seems pretty random to support 16 digits precisions here where everywhere
else it is 12...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
