adamsaghy commented on code in PR #4330:
URL: https://github.com/apache/fineract/pull/4330#discussion_r1954758256
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/LoanCOBCreateAccrualsTest.java:
##########
@@ -467,18 +473,14 @@ public void testEarlyRepaymentAccruals() {
||
"loanTransactionType.accrualAdjustment".equals(t.getType().getCode())));
// Accruals around installment due dates are as expected
-
Assertions.assertTrue(loanDetails.getTransactions().stream().anyMatch(
- t -> t.getDate().equals(LocalDate.of(2025, 1, 20)) &&
t.getType().getAccrual() && t.getAmount().equals(0.16D)));
-
Assertions.assertTrue(loanDetails.getTransactions().stream().anyMatch(
- t -> t.getDate().equals(LocalDate.of(2025, 1, 21)) &&
t.getType().getAccrual() && t.getAmount().equals(0.16D)));
-
Assertions.assertTrue(loanDetails.getTransactions().stream().anyMatch(
- t -> t.getDate().equals(LocalDate.of(2025, 2, 20)) &&
t.getType().getAccrual() && t.getAmount().equals(0.16D)));
-
Assertions.assertTrue(loanDetails.getTransactions().stream().anyMatch(
- t -> t.getDate().equals(LocalDate.of(2025, 2, 21)) &&
t.getType().getAccrual() && t.getAmount().equals(0.18D)));
-
Assertions.assertTrue(loanDetails.getTransactions().stream().anyMatch(
- t -> t.getDate().equals(LocalDate.of(2025, 3, 20)) &&
t.getType().getAccrual() && t.getAmount().equals(0.18D)));
-
Assertions.assertTrue(loanDetails.getTransactions().stream().anyMatch(
- t -> t.getDate().equals(LocalDate.of(2025, 3, 21)) &&
t.getType().getAccrual() && t.getAmount().equals(0.16D)));
+ validateTransactionsExist(loanDetails, //
+ transaction(0.16, "Accrual", "20 January 2025", 0.0, 0.0,
0.16, 0.0, 0.0, 0.0, 0.0), //
Review Comment:
These amounts are really weird to me.... How could be 0.16 and 0.18?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
