7ossam7atem1 opened a new pull request, #4367:
URL: https://github.com/apache/fineract/pull/4367
## Description
This PR fixes several code quality issues in
GLAccountReadPlatformServiceImpl class:
1. Merged nested if conditions using logical AND (&&) operator
- Combined nested if checks into single condition using && operator for
better readability
2. Renamed constant to follow Java naming convention
- Updated constant name to uppercase with underscores
(NAME_DECORATED_BASE_ON_HIERARCHY)
3. Removed unnecessary temporary variable
- Directly returned jdbcTemplate.queryForObject result instead of storing
in temp variable
4. Added explicit casting to resolve method call ambiguity
- Added (Object[]) cast to array parameters in jdbcTemplate.query calls
5. Replaced schema() method with constant
- Converted schema() method to static final String constant LOOKUP_SCHEMA
Ignore if these details are present on the associated [Apache Fineract JIRA
ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request
- thanks!
- [ ] Write the commit message as per
https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build
_("green")_ - it is your responsibility to get a proposed PR to pass the build,
not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at
https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with
details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in
repository" via a branch. Ask on the developer mailing list for guidance, if
required.)
FYI our guidelines for code reviews are at
https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
