a7med3del1973 commented on code in PR #4336:
URL: https://github.com/apache/fineract/pull/4336#discussion_r1966340590
##########
fineract-accounting/src/main/java/org/apache/fineract/accounting/accrual/serialization/AccrualAccountingDataValidator.java:
##########
@@ -46,8 +46,8 @@
@RequiredArgsConstructor
public final class AccrualAccountingDataValidator {
- private static final Set<String> LOAN_PERIODIC_REQUEST_DATA_PARAMETERS =
new HashSet<>(
- Arrays.asList(accrueTillParamName,
AccrualAccountingConstants.localeParamName,
AccrualAccountingConstants.dateFormatParamName));
+ private static final Set<String> LOAN_PERIODIC_REQUEST_DATA_PARAMETERS =
new HashSet<>(Arrays.asList(ACCRUE_TILL_PARAM_NAME,
+ AccrualAccountingConstants.LOCALE_PARAM_NAME,
AccrualAccountingConstants.DATE_FORMAT_PARAM_NAME));
Review Comment:
@VictorPavfurious hello victor
thanks for your time to review.. this change not attatched with maintenance
but good note for readability and maintainability of the code.. waiting your
feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
