adamsaghy commented on PR #4322: URL: https://github.com/apache/fineract/pull/4322#issuecomment-2677910578
@a7med3del1973 It looks okay, but it would be advisable to increase the scope of these PRs. For example here, you were refactoring `AcmeNoopJobConfiguration` to use constructor injection. You might wanna go through the whole Fineract (or at least one or multiple modules and do the same), we dont wanna have a separate commits for each classes... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
