adamsaghy commented on code in PR #4338:
URL: https://github.com/apache/fineract/pull/4338#discussion_r1967332930
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java:
##########
@@ -1349,13 +1349,11 @@ private void handleChargeOff(final LoanTransaction
loanTransaction, final Transa
Money feeChargesPortion = Money.zero(transactionCtx.getCurrency());
Money penaltychargesPortion = Money.zero(transactionCtx.getCurrency());
for (final LoanRepaymentScheduleInstallment currentInstallment :
transactionCtx.getInstallments()) {
- if (currentInstallment.isNotFullyPaidOff()) {
- principalPortion =
principalPortion.plus(currentInstallment.getPrincipalOutstanding(transactionCtx.getCurrency()));
- interestPortion =
interestPortion.plus(currentInstallment.getInterestOutstanding(transactionCtx.getCurrency()));
- feeChargesPortion =
feeChargesPortion.plus(currentInstallment.getFeeChargesOutstanding(transactionCtx.getCurrency()));
- penaltychargesPortion = penaltychargesPortion
-
.plus(currentInstallment.getPenaltyChargesOutstanding(transactionCtx.getCurrency()));
- }
+ principalPortion =
principalPortion.plus(currentInstallment.getPrincipalOutstanding(transactionCtx.getCurrency()));
Review Comment:
@magyari-adam I am not sure about this. If an installment is fully paid,
there cannot be any outstanding, so removing this condition looks incorrect to
me, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
