adamsaghy commented on code in PR #4357:
URL: https://github.com/apache/fineract/pull/4357#discussion_r1967609205
##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/EntityTables.java:
##########
@@ -66,15 +65,15 @@ public enum EntityTables {
@NotNull
private final String refColumn; // referenced column name on apptable
- private final ImmutableList<StatusEnum> checkStatuses;
+ private final List<StatusEnum> checkStatuses;
EntityTables(@NotNull String name, @NotNull String apptableName, @NotNull
String foreignKeyColumnNameOnDatatable,
@NotNull String refColumn, StatusEnum... statuses) {
this.name = name;
this.apptableName = apptableName;
this.foreignKeyColumnNameOnDatatable = foreignKeyColumnNameOnDatatable;
this.refColumn = refColumn;
- this.checkStatuses = statuses == null ? ImmutableList.of() :
ImmutableList.copyOf(statuses);
+ this.checkStatuses = statuses == null ? List.of() :
List.copyOf(Arrays.asList(statuses));
Review Comment:
Is there any reason to change from `ImmutableList` to `List`?
Also we Dont need multiple copyint... a simple `List.of(statuses)` enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
