adamsaghy commented on code in PR #4334:
URL: https://github.com/apache/fineract/pull/4334#discussion_r1969877100
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanAccrualActivityProcessingServiceImpl.java:
##########
@@ -122,7 +122,11 @@ public void processAccrualActivityForLoanClosure(@NotNull
Loan loan) {
if (installmentAccruals.isEmpty()) {
// No AAT for this installment; create one
- makeAccrualActivityTransaction(loan, installment,
installment.getDueDate());
+ LocalDate transactionDate = installment.getDueDate();
+ if (loan.isOverPaid() &&
installment.getDueDate().isAfter(loan.getOverpaidOnDate())) {
Review Comment:
I am afraid of commenting out is not enough....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
