oleksii-novikov-onix commented on code in PR #4391:
URL: https://github.com/apache/fineract/pull/4391#discussion_r1974156120
##########
fineract-provider/src/main/java/org/apache/fineract/adhocquery/api/AdHocApiResource.java:
##########
@@ -63,70 +60,59 @@ public class AdHocApiResource {
private final PlatformSecurityContext context;
private final AdHocReadPlatformService adHocReadPlatformService;
private final DefaultToApiJsonSerializer<AdHocData> toApiJsonSerializer;
- private final ApiRequestParameterHelper apiRequestParameterHelper;
private final PortfolioCommandSourceWritePlatformService
commandsSourceWritePlatformService;
@GET
@Consumes({ MediaType.APPLICATION_JSON })
@Produces({ MediaType.APPLICATION_JSON })
- public String retrieveAll(@Context final UriInfo uriInfo) {
+ public Collection<AdHocData> retrieveAll() {
Review Comment:
I think it's better to use List instead of Collection
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
