Harsh-Srivastav123 opened a new pull request, #4397:
URL: https://github.com/apache/fineract/pull/4397
## Description
The code was changed from:
return name().toString().replaceAll("_", " ");
to
return name().replace("_", " ");
### Changes made:
- Removed redundant toString() call since name() already returns a String
- Changed replaceAll() to replace() since we're replacing a simple
character, not a regex pattern
### Why needed:
- Removes unnecessary method calls
- Improves code readability
- More efficient since replace() is faster than replaceAll() for simple
character replacement
Aligns with similar implementations in other enums like
JournalEntryJsonInputParams (lines 54-56)
The change is safe and verified through accounting module tests, maintaining
the same functionality with cleaner code.
Ignore if these details are present on the associated [Apache Fineract JIRA
ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request
- thanks!
- [ ] Write the commit message as per
https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build
_("green")_ - it is your responsibility to get a proposed PR to pass the build,
not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at
https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with
details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in
repository" via a branch. Ask on the developer mailing list for guidance, if
required.)
FYI our guidelines for code reviews are at
https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
