Cocoa-Puffs commented on code in PR #4405: URL: https://github.com/apache/fineract/pull/4405#discussion_r1981468035
########## integration-tests/src/test/java/org/apache/fineract/integrationtests/LoanCatchUpIntegrationTest.java: ########## @@ -52,8 +52,10 @@ import org.apache.http.HttpStatus; import org.junit.jupiter.api.Assertions; import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.Order; import org.junit.jupiter.api.Test; +@Order(1) Review Comment: This test broke non deterministically. When I pushed the branch the tests ran without problems, but that test failed on the pr. I have another branch in the works and on that branch the tests failed, but ran without errors on the pr. I wrote to @adamsaghy about this and he suggested adding an order on that test so it would run first. Thereby minimizing the chance of the test failing due to the async validations and checks in it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
