adamsaghy commented on code in PR #4307:
URL: https://github.com/apache/fineract/pull/4307#discussion_r1982277822
##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/ResultsetColumnHeaderData.java:
##########
@@ -239,40 +206,58 @@ private DisplayType calcDisplayType() {
}
public static DisplayType calcColumnDisplayType(JdbcJavaType columnType) {
+ return switch (getJdbcType(columnType)) {
Review Comment:
I see no any value of this changes....
If you want to change the IF conditions to switch fine... but why to map
JdbcJavaType to String and from String to DisplayType?
Map JdbcJavaType to DisplayType with mapper if you want...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
