adamsaghy commented on code in PR #4388:
URL: https://github.com/apache/fineract/pull/4388#discussion_r1982281143
##########
fineract-provider/src/main/java/org/apache/fineract/commands/api/AuditsApiResource.java:
##########
@@ -63,19 +59,15 @@
@RequiredArgsConstructor
public class AuditsApiResource {
- private static final Set<String> RESPONSE_DATA_PARAMETERS = new
HashSet<>(Arrays.asList("id", "actionName", "entityName", "resourceId",
- "subresourceId", "maker", "madeOnDate", "checker",
"checkedOnDate", "processingResult", "commandAsJson", "officeName",
- "groupLevelName", "groupName", "clientName", "loanAccountNo",
"savingsAccountNo", "clientId", "loanId", "url"));
-
private static final String RESOURCE_NAME_FOR_PERMISSIONS = "AUDIT";
private final PlatformSecurityContext context;
private final AuditReadPlatformService auditReadPlatformService;
private final ApiRequestParameterHelper apiRequestParameterHelper;
- private final DefaultToApiJsonSerializer<AuditData> toApiJsonSerializer;
- private final DefaultToApiJsonSerializer<AuditSearchData>
toApiJsonSerializerSearchTemplate;
- private final SqlValidator sqlValidator;
+ private final ToApiJsonSerializer<String> toApiJsonSerializer;
+ // todo: why response dto depend to query param paged..? Impossible
refactor normally. Probably need to separate to
Review Comment:
You can raise a question in the Fineract DEV mail list whether people are
using the List or Paged version and recommend to deprecate one of them.
Personally, only the paged version should be here!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
