adamsaghy commented on code in PR #4430:
URL: https://github.com/apache/fineract/pull/4430#discussion_r1985139447
##########
fineract-e2e-tests-core/src/test/java/org/apache/fineract/test/messaging/event/EventCheckHelper.java:
##########
@@ -198,7 +199,8 @@ private void loanAccountDataV1Check(Class<? extends
AbstractLoanEvent> eventClaz
Long clientIdExpected = body.getClientId();
BigDecimal principalDisbursedActual =
loanAccountDataV1.getSummary().getPrincipalDisbursed();
Double principalDisbursedExpectedDouble =
body.getSummary().getPrincipalDisbursed();
- BigDecimal principalDisbursedExpected = new
BigDecimal(principalDisbursedExpectedDouble, MathContext.DECIMAL64);
+ BigDecimal principalDisbursedExpected = new
BigDecimal(principalDisbursedExpectedDouble, MathContext.DECIMAL64)
Review Comment:
why the hardcoded hald_down? This sounds incorrect to me
##########
fineract-e2e-tests-core/src/test/java/org/apache/fineract/test/messaging/event/EventCheckHelper.java:
##########
@@ -198,7 +199,8 @@ private void loanAccountDataV1Check(Class<? extends
AbstractLoanEvent> eventClaz
Long clientIdExpected = body.getClientId();
BigDecimal principalDisbursedActual =
loanAccountDataV1.getSummary().getPrincipalDisbursed();
Double principalDisbursedExpectedDouble =
body.getSummary().getPrincipalDisbursed();
- BigDecimal principalDisbursedExpected = new
BigDecimal(principalDisbursedExpectedDouble, MathContext.DECIMAL64);
+ BigDecimal principalDisbursedExpected = new
BigDecimal(principalDisbursedExpectedDouble, MathContext.DECIMAL64)
Review Comment:
why the hardcoded hald_down? This looks incorrect to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
