adamsaghy commented on code in PR #4394:
URL: https://github.com/apache/fineract/pull/4394#discussion_r1985127242
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadWriteNonCoreDataServiceImpl.java:
##########
@@ -1353,6 +1357,11 @@ private CommandProcessingResult
createNewDatatableEntry(final String dataTableNa
if (isMultirowDatatable(columnHeaders)) {
resourceId = sqlGenerator.fetchPK(keyHolder);
}
+
Review Comment:
Would you mind to create some unit tests, that is covering whether the
DatatableEntryCreatedBusinessEvent / DatatableEntryUpdatedBusinessEvent /
DatatableEntryDeletedBusinessEvent events with the correct data is called?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
