adamsaghy commented on code in PR #4434:
URL: https://github.com/apache/fineract/pull/4434#discussion_r1987673803
##########
fineract-accounting/src/main/java/org/apache/fineract/accounting/provisioning/api/ProvisioningEntriesApiResource.java:
##########
@@ -137,41 +113,51 @@ public String
modifyProvisioningEntry(@PathParam("entryId") @Parameter(descripti
@Produces({ MediaType.APPLICATION_JSON })
@Operation(summary = "Retrieves a Provisioning Entry", description =
"Returns the details of a generated Provisioning Entry.")
@ApiResponse(responseCode = "200", description = "OK", content =
@Content(schema = @Schema(implementation = ProvisioningEntryData.class)))
- public String retrieveProvisioningEntry(@PathParam("entryId")
@Parameter(description = "entryId") final Long entryId,
- @Context final UriInfo uriInfo) {
+ public ProvisioningEntryData
retrieveProvisioningEntry(@PathParam("entryId") @Parameter(description =
"entryId") final Long entryId) {
platformSecurityContext.authenticatedUser();
- ProvisioningEntryData data =
this.provisioningEntriesReadPlatformService.retrieveProvisioningEntryData(entryId);
- final ApiRequestJsonSerializationSettings settings =
this.apiRequestParameterHelper.process(uriInfo.getQueryParameters());
- return this.toApiJsonSerializer.serialize(settings, data,
PROVISIONING_ENTRY_PARAMETERS);
+ return
provisioningEntriesReadPlatformService.retrieveProvisioningEntryData(entryId);
}
@GET
@Path("entries")
@Consumes({ MediaType.APPLICATION_JSON })
@Produces({ MediaType.APPLICATION_JSON })
@ApiResponse(responseCode = "200", description = "OK", content =
@Content(schema = @Schema(implementation =
LoanProductProvisioningEntryData.class)))
Review Comment:
You might wanna remove the swagger annotation here as it is not matching
with the "real" response:
`LoanProductProvisioningEntryData` vs
`Page<LoanProductProvisioningEntryData>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
