meonkeys opened a new pull request, #4470: URL: https://github.com/apache/fineract/pull/4470
## Description * don't bother making MD5 files, they aren't necessary * step12 changed, stub it out and reference FINERACT-1817 for future improvements (looks like svn mv is not yet supported) * use latest vote message template, based on https://lists.apache.org/thread/cs5t0ho39ktg2jxr74dqd7fg9nyfcz3k * use more explicit form of `git push` to push release tag, see https://stackoverflow.com/questions/5195859/how-do-you-push-a-tag-to-a-remote-repository-using-git * use consistent language re: tarball, file, artifact, release candidate * fix some source listings that shouldn't be using macro expansion: this messes up URLs (hides scheme) * fix asciidoc link to FINERACT-1229 * clean up copyright years: use variable properly and remove unnecessary extra copyright in preface (it appears directly above, in the license) * de-indent URL in apache license -- this makes the link clickable in rendered HTML and PDF asciidoc outputs See also: https://issues.apache.org/jira/browse/FINERACT-2219 I built and posted rendered versions of the asciidoc for this PR at: * https://adammonsen.com/tmp/FINERACT-2219/htmldoc/ * https://adammonsen.com/tmp/FINERACT-2219/docs.pdf ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [x] Write the commit message as per https://github.com/apache/fineract/#pull-requests - [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [x] Create/update unit or integration tests for verifying the changes made. - [x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions. - [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [x] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.) FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
