galovics commented on code in PR #4498: URL: https://github.com/apache/fineract/pull/4498#discussion_r2014133816
########## fineract-provider/src/main/resources/db/changelog/tenant-store/parts/0005_jdbc_connection_string.xml: ########## @@ -22,9 +22,26 @@ <databaseChangeLog xmlns="http://www.liquibase.org/xml/ns/dbchangelog" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-4.1.xsd"> + <changeSet author="fineract" id="1" context="tenant_store_db"> - <update tableName="tenant_server_connections"> - <column name="schema_connection_parameters" value="serverTimezone=UTC&useLegacyDatetimeCode=false&sessionVariables=time_zone='-00:00'"/> - </update> + <sql dbms="postgresql"> Review Comment: Wouldn't it make more sense to create a new changelog and check if the value in the DB is the default? If it is, just override it to the right value this once. If it isn't, just leave it as it is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
