JebronLames32 commented on code in PR #4522:
URL: https://github.com/apache/fineract/pull/4522#discussion_r2020130900
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanWritePlatformServiceJpaRepositoryImpl.java:
##########
@@ -2877,7 +2877,7 @@ public CommandProcessingResult chargeOff(JsonCommand
command) {
throw new
GeneralPlatformDomainRuleException("error.msg.loan.is.already.charged.off",
"Loan: " + loanId + " is already charged-off", loanId);
}
- if (DateUtils.isBefore(transactionDate,
loan.getLastUserTransactionDate())) {
+ if (DateUtils.isBefore(transactionDate,
loan.getLastNonReversedUserTransactionDate())) {
Review Comment:
The only issue was with the `hasMonetaryActivityAfter` function. As
mentioned in the
[FINERACT-2215](https://issues.apache.org/jira/browse/FINERACT-2215) ticket,
the error message that is showing is
`"charge-off cannot be executed. Loan has monetary activity after the
charge-off transaction date!"`
and not `"charge-off cannot be executed. User transaction was found after
the charge-off transaction date!"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
