oleksii-novikov-onix commented on code in PR #4520:
URL: https://github.com/apache/fineract/pull/4520#discussion_r2020696019
##########
fineract-progressive-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/transactionprocessor/impl/AdvancedPaymentScheduleTransactionProcessor.java:
##########
@@ -1892,6 +1900,7 @@ private Money
processAllocationsHorizontally(LoanTransaction loanTransaction, Tr
// run ouf of unallocated amounts
.filter(i -> i.isNotFullyPaidOff() ||
i.isDueBalanceZero()) //
.filter(e -> loanTransaction.isBefore(e.getDueDate()))
//
+ .filter(e -> !alreadyProcessedInstallments.contains(e))
Review Comment:
This filter would never exclude any installments since
alreadyProcessedInstallments is always empty at the beginning of the method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
