Lymah123 commented on PR #4536: URL: https://github.com/apache/fineract/pull/4536#issuecomment-2775387970
Thank you for the feedback @adamsaghy . You're absolutely right that simply changing the variable in one configuration file is insufficient if AWS_ENDPOINT_URL is used throughout the codebase. I'd like to propose a more comprehensive approach: 1. First, I'll identify all places where AWS_ENDPOINT_URL is used in the codebase 2. Implement a transition strategy that supports both variables (with preference for FINERACT_AWS_ENDPOINT) 3. Add appropriate deprecation warnings when the old variable is used 4. Update all configuration examples and documentation Questions for you: 1. Is there a preferred timeline for deprecating `AWS_ENDPOINT_URL` completely? 2. Should I implement this as a single PR or would you prefer it broken into smaller changes? 3. Are there specific areas of the codebase I should focus on first? 4. Is there existing code that handles environment variables that I should leverage for consistency? I want to ensure this change follows best practices for the project and provides a smooth transition for users. Any guidance you can provide would be appreciated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
